Use possessive quantifiers in @covers annotation expression #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
There was a problem hiding this comment.
Why did you remove these test cases?
Contributor
Author
There was a problem hiding this comment.
They're not test cases. They're coverage annotations in the tests. The test cases are in TEST_FILES_PATH.
See #108, "I'm not too sure about how to go about testing this, so I changed some of the covers annotations in the CodeCoverageTest.php test case to include the supported ways of using the parenthesis."
sebastianbergmann
added a commit
that referenced
this pull request
May 11, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These perform faster than the current backtracking, and I find the function/method expression easier to read.